zouhir / jarvis

A very intelligent browser based Webpack dashboard

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Crash when open jarvis url

sergeysova opened this issue · comments

commented

In repo https://github.com/sergeysova/InstaClone/tree/feature/jarvis

Run webpack-dev-server with npm script dev:webpack or npx webpack --watch.

Next I see:

image

But if I try to open http://localhost:3005, jarvis crashes:

image

same crash with npx webpack --watch.

Node: 8.9.4
Webpack: 3.11.0
macOS: 10.13.4 Beta

https://github.com/sergeysova/InstaClone/blob/feature/jarvis/package.json#L82-L93

I was seeing this too (node 8.9.4, webpack 2.7.0, webpack-dev-server 2.11.1) - looks like it's a regression with serve-static 1.13.2, that's fixed by forcing 1.13.1 to be used, eg via the yarn selective resolutions feature:

  "resolutions": {
    "serve-static": "1.13.1"
  },

Changelog:
expressjs/serve-static@v1.13.1...v1.13.2

Hi there, I just cloned your project & checked it, it seems OK on my end!
screen shot 2018-02-26 at 21 49 42

commented

@zouhir what's your OS and Nodejs version?

Same problem (next is not a function) occurring for me as well. Both with "serve-static": "1.13.1" as well as "serve-static": "1.13.2").
OS: Windows10, nodejs: 9.6.1

Thanks to both of you for reporting this issue!

What is happening, serve static isn't able to find the dist folder where I have Jarvis page & assets.

I'll investigate closely...

Same problem for me.

Node: 8.9.4
webpack: 3.11.0
serve-static: first didn't install manually, also tried with 1.13.2

hey everyone,

I've only been able to see this if the node server did not find the client index.html in dist folder.

This issue seems to happen with only few people, can you please validate if:

1- You can see dist and index.html in your node_modules
2- rm -rf node_modules and get a fresh version from npm?

@zouhir

You can see dist and index.html in your node_modules

dist folder, I assume? Build time of my project is about 1 minute, but Jarvis is started right after npm start. Could it be due to there is no index.html in dist folder at that moment?

please check now, v0.3.1 is released!

@zouhir It works now (node v8.1.3, webpack 3.11.0) :) Thanks !

woohoo!!!!! I look forward to taking Jarvis out of beta ASAP! sorry for being a bit of a problem!