zotero / zotero-android

Zotero for Android

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Sticky note annotation still using pspdfkit ui

stakats opened this issue · comments

We should be using our simplified edit dialog instead.

commented

@stakats @dstillman I asked PSPDFKIT team regarding this and here is their reply. I wonder what should we do about it then:

"Unfortunately, there's no current feasible way to avoid this because the editor is started as soon as the note is created."

commented

Here is what we are discussing:
https://ibb.co/N7CK7Ls

This is different from iOS somehow? We can't support sticky notes if we can't show our own dialog…

commented

It's different in a way that in iOS you can easily prevent this pspdfkit dialog from appearing with a simple code config, but on Android there is, as it surprisingly turns out, no way.

I mean, then we need to communicate that this is a blocker for us. We can't support sticky-note editing at all — or release a non-beta version of the app — if we can't prevent their UI from showing. Like, horrible UI aside, this lets you set a question mark or a star as the annotation icon. (The comment field also doesn't seem to be hooked up to our storage, but that doesn't matter — we can't use this anyway.)