Move code in ./common into the main directory?

Question

Move code in ./common into the main directory?

joeyak opened this issue 2 years ago · comments

Now that wasm is being removed in #168 we can move the code in common out because it's not longer being used. Now an alternative to that is leave it in common because it does break up the code somewhat into smaller sections.

CptPie · Answer 1 · Mon Mar 14 2022 01:39:37 GMT+0800 (China Standard Time)

Speaking from my own (biased) opinion/experience with moviepolls, i would try to keep your main directory as "clean" as possible, basically only having the main.go, buildfiles and other stuff (linter config) in the main dir.

joeyak · Answer 2 · Mon Mar 14 2022 01:44:38 GMT+0800 (China Standard Time)

hmm good point. Maybe we need to restructure the root directory a bit more? One thing I definitely want to do is combine emotes.go and common/emotes.go

Zorglube · Answer 3 · Mon Mar 14 2022 20:21:10 GMT+0800 (China Standard Time)

Il vote for @CptPie point of view ! (Whatever worth my vote 🤣).

joeyak · Answer 4 · Fri Oct 21 2022 07:59:53 GMT+0800 (China Standard Time)

common/emotes was combined into emotes.go with the embed branch