headsup for MAJOR overhaul of ObjectWidget PR
agroszer opened this issue · comments
Adam Groszer commented
see #38
please review or comment
when noone objects will merge in a week
Martronic SA commented
collective.z3cform.datagridfield is broken by that commit.
I don't know if it will be possible to fix with thoses changes.. ?
Adam Groszer commented
Sorry, ObjectWidget was PITA. You could pin z3c.form at a version that's compatible with collective.z3cform.datagridfield
Johannes Raggam commented
Shouldn't the general zopefoundation code review rules - getting review from another person - also apply to z3c.form?
Your self-merged changes for z3c.form 3.3.0 (should actually be a 4.0 release) introduces hard-to-resolve incompatibilities with Plone. And Plone is probably the biggest consumer of this project.