Giters

zoontek / react-native-bootsplash

🚀 Show a splash screen during app startup. Hide it when you are ready.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Small icon size on Samsung devices with Android 12

Navipro70 opened this issue · comments

commented

Before submitting a new issue

  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.

Bug summary

On some samsung devices with android 12 splash screen icon is ~5 times smaller compared to other Android/IOS devices.

Splash Icon on Samsung device from list of devices enumerated in Environment info:
BrokenSamsungSplash

Splash Icon on Nexus 4:
Screenshot_1714475206

Library version

5.4.0

Environment info

Reproducible devices:
Samsung Galaxy S22 Ultra Android 12.0
Samsung Galaxy S22 Android v12.0
Samsung Galaxy S21 Android v12.0
Samsung Galaxy S20 Android v12.0

Steps to reproduce

  1. Generate splash screen with bootsplash command: yarn react-native generate-bootsplash pathToLogo --background=E52E6B --logo-width=142
  2. Run any device from Environment info devices list

Reproducible sample code

`yarn react-native generate-bootsplash pathToLogo --background=E52E6B --logo-width=142`
commented

@Navipro70 Hey! You ticked the "I checked for possible duplicate issues, with possible answers" but didn't: #466

There's nothing we can do as the issue occurs on system thread (It's an issue with OneUI v4, Samsung fixed it only with OneUI v5)

commented

@zoontek Hello! Thanks for fast reply.

I've already checked issue above, but the title is wrong. In my case logo is not half sized, it's ~5 times smaller than on another devices.

And also I didn't understand, what solution was applied to the #466? Can you please provide actual information about that problem and why we can't fix it, because other apps have normal icon size on Samsung with Android 12

commented

I've already checked issue above, but the title is wrong. In my case logo is not half sized, it's ~5 times smaller than on another devices.

It doesn't look like 5 times smaller to me. You specified 142 dp for logo width, it looks like half size here (71 dp). Don't forget that a Nexus 4 and a Samsung Galaxy Ultra don't have identical screen resolutions.
You should compare with a device with identical screen (a custom emulator could achieve that) to notice that it has indeed half the width and half the height (which means it takes 1/4 of the space it should).

And also I didn't understand, what solution was applied to the #466?

Can you please provide actual information about that problem and why we can't fix it

#466 (comment)

Because other apps have normal icon size on Samsung with Android 12

There's hacks all around to delay the app launch (and removes all interest to the SplashScreen API, as its initial goal was to make the opening faster), but it cames with its own issues.

This library choosed to degrade the experience of Samsung users stucked on OneUI v4 (android 12 + they can't update) by not hiding the mistake Samsung made when implementing the API, instead of delaying all android 12 users app opening experience. It's a compromise 🤷🏻‍♂️