zonkyio / ember-web-app

This Ember addon helps you configure and manage the Web App Manifest to create Progressive Web App

Home Page:https://zonkyio.github.io/ember-web-app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Allow purpose icon attribute in manifest.js

AmauryD opened this issue · comments

Hello,

I get a warning message when i use the purpose attribute in icons.

My manifest.js file (simplified):

module.exports = function(/* environment, appConfig */) {
  return {
    ...
    icons: [
      ...
      {
        src: '/assets/favicons/maskable_icon.png',
        sizes: '512x512',
        type: "image/png",
        purpose: "maskable"
      }
  }
}

WARNING: manifest.webmanifest validation: Unknown icon attribute "purpose".

The property seems to be moved (at least Lighthouse is ok with it) to manifest.webmanifest but the warning message is a little confusing, purpose should be a valid attribute.

Hi 👋,

this warning comes from web-app-manifest-validator, it looks that it is already fixed in master by san650/web-app-manifest-validator#8 😍.

I'll update and release patch version when available, until then this warning can be ignored, sorry for the confusion.

I've released a new version of web-app-manifest-validator

Released as v5.0.1 🚀.