How to add crossorigin="use-credentials"

Question

How to add crossorigin="use-credentials"

tschoartschi opened this issue 5 years ago · comments

We have our web app behind a http basic auth, therefore we need to add crossorigin="use-credentials" to the <link rel="manifest" href="/manifest.json"> Tag.

For more details about manifest and http basic auth you can visit the link: https://thatemil.com/blog/2018/02/21/pwa-basic-auth/

Jan Bobisud · Answer 1 · Wed Apr 03 2019 03:22:06 GMT+0800 (China Standard Time)

Hi 👋,

thanks for opening the issue, AFAIK it's not currently possible, but adding the crossorigin parameter into add-on should work fine.

Georg Kothmeier · Answer 2 · Mon Apr 15 2019 15:47:25 GMT+0800 (China Standard Time)

@bobisjan thanks for the feedback 😃 do you have any idea when this could be included?

Jan Bobisud · Answer 3 · Sat Apr 27 2019 18:02:23 GMT+0800 (China Standard Time)

@tschoartschi, will take a look during this weekend 🙂.

Georg Kothmeier · Answer 4 · Fri May 03 2019 20:55:06 GMT+0800 (China Standard Time)

@bobisjan thanks for the quick fix 😃 I'll have a look on it beginning of next week and I'll give you feedback

Jan Bobisud · Answer 5 · Tue May 07 2019 01:31:53 GMT+0800 (China Standard Time)

@tschoartschi, it's in master, you can test and report back if something went wrong ☺️.