zobo / php-language-server

PHP Implementation of the VS Code Language Server Protocol 🆚↔🖥

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

textDocument/signatureHelp response is invalid

veksha opened this issue · comments

I send textDocument/signatureHelp
and get an invalid response from server: {'signatures': null, 'activeSignature': null, 'activeParameter': null}

according to LSP specs If no signatures are available the signature help request should return "null".

null values are not valid for members of SignatureHelp interface.

export interface SignatureHelp {
	/**
	 * One or more signatures. If no signatures are available the signature help
	 * request should return `null`.
	 */
	signatures: SignatureInformation[];
        activeSignature?: uinteger;
        activeParameter?: uinteger;

Doesn't seem to make much difference in VsCode, but I can change this. Thanks.

I'm using it in CudaText. it complains in status bar:
image
This is not a crash, but still it is better to stick to the specification.

Thanks!

BTW: I'm planning to open an issue about this server is not working in stdio mode. only working through TCP socket. Can you confirm it is not working for you too?

It seems the STDIO has a problem with blocking reads. I'll look into it if it can be resolved...

I did look into it a bit more. I work on windows and there reading from STDIN and not blocking on it seems just... impossible...
I strongly suggest you use TCP.

okay thank you.