Duplicated labels when `input`/`label` pairings are siblings

[brendanarnold-bjss]

Hi,

Great project, very useful :)

I wanted to check this behaviour is intentional ...

If I have the following bit of HTML

<label>
  <input type="radio" />
  Some text
</label>

Then we get the following result in the preview ...

However if I have the following HTML (which is also a valid) ...

<input id="my-radio" type="radio" />
<label for="my-radio'>Some text</label>

Then the output looks like ...

You can see the label text is duplicated

This is being raised as a bug in my project and I wanted to know if it really is what a screenreader would render?

Cheers,
Brendan

[Mateusz Zieliński]

Hi,

It seems that e.g. NVDA does not read the the text twice for labels with HTML for attribute.

I've fixed this and published a new version to Google Web Store. It may take a few days before this version gets verified by Google and updated on your device.

Cheers,
Mateusz

[brendanarnold-bjss]

Hi Mateusz, That sounds promising – I’ll keep an eye out in the next few days. Thanks for looking into it. The original duplication meant that as a fix a change was put into our codebase where the label was being hidden from the a11y tree using the aria-hidden attribute. As far as I can tell, this means that the label would be hidden from screenreaders which is probably not what we want! Thanks for looking into it and the speedy turnaround Brendan From: Mateusz Zieliński ***@***.***> Date: Sunday, 16 May 2021 at 20:30 To: ziolko/aria-devtools ***@***.***> Cc: Brendan Arnold ***@***.***>, Author ***@***.***> Subject: Re: [ziolko/aria-devtools] Duplicated labels when `input`/`label` pairings are siblings (#7) Hi, It seems that e.g. NVDA does not read the the text twice for labels with HTML for attribute. I've fixed this and published a new version to Google Web Store. It may take a few days before this version gets verified by Google and updated on your device. Cheers, Mateusz — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#7 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASZUUAKSPXOVOECSGD7GOBTTOAMMTANCNFSM444FFW7A>. The information included in this email and any files transmitted with it may contain information that is confidential and it must not be used by, or its contents or attachments copied or disclosed to, persons other than the intended addressee. If you have received this email in error, please notify BJSS. In the absence of written agreement to the contrary BJSS' relevant standard terms of contract for any work to be undertaken will apply. Please carry out virus or such other checks as you consider appropriate in respect of this email. BJSS does not accept responsibility for any adverse effect upon your system or data in relation to this email or any files transmitted with it. BJSS Limited, a company registered in England and Wales (Company Number 2777575), VAT Registration Number 613295452, Registered Office Address, 1 Whitehall Quay, Leeds, LS1 4HR

[Mateusz Zieliński]

I am happy to help. Keep in mind that ARIA DevTools can help you with the development of accessible websites but you should still test your products with an actual screen reader at some point.

For now, I am closing this issue. Feel free to reopen it or raise another one in case of any further problems.

Also, if you are happy with the tool, please remember to star this Github repository and leave a positive review on Chrome Web Store :)