Giters

ziolko / aria-devtools

Easily spot missing ARIA labels, misused ARIA roles, and incomplete keyboard support in your web applications.

Home Page:https://chrome.google.com/webstore/detail/aria-devtools/dneemiigcbbgbdjlcdjjnianlikimpck?hl=en

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug] Extension throws error due to table

ppfabian opened this issue · comments

commented

Hi, great extension! Love using it.

On https://news.ycombinator.com/item?id=28167012, when clicking on the extension icon, for a moment the website turns black and then switches to normal again. The following is displayed in the console:

TypeError: a.rows[s] is undefined
    l moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:74
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:74
    Se moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    computeValue moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    trackAndCompute moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    read moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:74
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:74
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:74
    Se moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    computeValue moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    trackAndCompute moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    read moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:74
    Se moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    computeValue moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    trackAndCompute moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    read moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:74
    Se moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    computeValue moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    trackAndCompute moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    read moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    get moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:74
    C moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:114
    i moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:46
    m moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:46
    Se moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    track moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:44
    m moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:46
    i moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:46
    Si moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    uo moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    io moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    ao moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    Bo moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    Qu moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    Bu moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    Iu moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    sa moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    unstable_runWithPriority moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:8
    ia moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    sa moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    ca moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    Zu moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    unstable_runWithPriority moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:8
    ia moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    Gu moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    Xu moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:12
    E moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:8
    onmessage moz-extension://d940bee7-cd33-d94f-baf3-2772ad7ba355/inject.js:8

I am on Firefox 90.0.2 (macOS). I expected that the extension doesn't throw an error and maybe display the usual content (even tho the websites still uses tables for the layout).

commented

Thanks for the bug request. This is already fixed on Chrome. Let me release a new version for firefox as well.

commented

Ok, the new version is available at the Firefox browser add-ons gallery. Please let me know if it works as expected now.

Mateusz

commented

Hi @ziolko,

can confirm, it is now working. :)

Thanks!

commented

That's great! Feel free to star this repository and leave a positive review at the Firefox add-on page.

As this is something I develop in my free time small things like this keep me motivated 😉