[Bug] Command "show loading_progress" is unusable
WuYiFan0108 opened this issue · comments
Command "show loading_progress" errors anyway no matter how I use this command:
After some look up, I found that milvus_cli passes the partition parameter of tuple type to pymilvus, but pymilvus only accepts the partition parameter of list type, resulting in the above error.
I think there are two solutions to this issuse:
- Implement a callback function in "show loading_progress" which transform the partition parameter of tuple type to list type.
- Modify pymilvus to make pymilvus support partition_arrary parameter input of tuple type.
I personally prefer solution 1 because it this has the least impact on the whole Milvus project, and I've already implemented this.
Please let me know what you think.
Will have a new release to support new Milvus and Pymilvus asps. Also will fix this issue.
Will have a new release to support new Milvus and Pymilvus asps. Also will fix this issue.
So, I guess there is no need to open a new pull request?
@WuYiFan0108 Yes, we will refactor the codes by new pymilvus. Thanks for your suggestions. Any update will let you know!
@WuYiFan0108 please have a try with new release v0.4.0. Thanks
It's working well. Nice job on the refactoring!👍