improve the iterator implementation
zhengbuqian opened this issue · comments
Buqian Zheng commented
so that we can avoid as much duplicate code between indexes as possible and form a good foundation for Cardinal to add iterator support
Buqian Zheng commented
TODOs after #501:
- hnsw iterator use brute force for high filter rate
- hnsw iterator to limit
to_visit
size by search 1 step every severalNext()
calls. - ivf iterator to copy and own query data
- DiskANN iterator impl
- IVF-SQ8 iterator impl: this is being targeted in #414
- HNSW impl has support for binary vector, but it is not officially supported. Thus hnsw iterator on binary vector is not properly tested: this is being targeted in #494
- make the parameters configurable
github-actions commented
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.