Introduce :private in Maxwell.Conn struct

Question

Introduce :private in Maxwell.Conn struct

imranismail opened this issue 8 years ago · comments

For example there are use cases where I need a raw_body instead of a decoded one, I don't want to encode it back to json since it's expensive.

Instead I want to add a middleware that populates the :private map in conn struct with raw_body

and let the json middleware do it's job.

Can we introduce a :private attribute in Maxwell.Conn for this?

additional suggested functions to add to Maxwell.Conn

get_private/2
put_private/3

Paul Schoenfelder · Answer 1 · Mon Jan 16 2017 15:37:29 GMT+0800 (China Standard Time)

I'm 👍 on this. I can get this implemented this week.

Imran Ismail · Answer 2 · Mon Jan 16 2017 16:35:42 GMT+0800 (China Standard Time)

@bitwalker can I handle this one? It's pretty simple 😄

Paul Schoenfelder · Answer 3 · Mon Jan 16 2017 16:40:01 GMT+0800 (China Standard Time)

Sure thing :), though you may want to wait until #36 is merged, because that PR updates the internals a bit, and it'll save you some hassle rebasing later on.

Imran Ismail · Answer 4 · Mon Jan 16 2017 16:40:42 GMT+0800 (China Standard Time)

Yeap, I'm watching that PR. Thanks!