zeromq / libzmq

ZeroMQ core engine in C++, implements ZMTP/3.1

Home Page:https://www.zeromq.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Variable $enable_drafts is used before it is assigned in configure.ac

ellert opened this issue · comments

[enable_ws=$enable_drafts])

In the line above, the variable $enable_drafts is used before it is assigned. The intended purpose of using the value of --enable-drafts as the defaut value for ----enable-ws is therefore not accomplished.

Since due to the above the default value for enable_ws is the empty string, the condition

if test "x$enable_ws" != "xno"; then

results in that ws will be enabled by default. To make this explicit (and so that ./configure --help shows the default that is actually used) this could be changed to:

AC_ARG_ENABLE([ws],
    [AS_HELP_STRING([--enable-ws], [Enable WebSocket transport [default=yes]])],
    [enable_ws=$enableval],
    [enable_ws=yes])