Add support for PHP 7.2's `object` type hint

Question

Add support for PHP 7.2's `object` type hint

Ocramius opened this issue 7 years ago · comments

Marco Pivetta · Answer 1 · Mon Jun 26 2017 22:28:22 GMT+0800 (China Standard Time)

If you never contributed and need pointers, check #87 on a previous patch that added PHP 7.1 features (look for the iterable hint)

Stéphane HULARD · Answer 2 · Mon Jun 26 2017 23:31:00 GMT+0800 (China Standard Time)

Hello !

I'll be glad to take a look 😄.

Is the impact exactly the same than iterable hint ? Seems more complicated in the tests than in the code...

Marco Pivetta · Answer 3 · Tue Jun 27 2017 01:50:50 GMT+0800 (China Standard Time)

Yes, same impact as `iterable`, and indeed, it's about tests 👍

…

On 26 Jun 2017 5:31 PM, "Stéphane HULARD" ***@***.***> wrote: Hello ! I'll be glad to take a look 😄. Is the impact exactly the same than iterable hint ? Seems more complicated in the tests than in the code... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakDAqameByN-p5eCtuapcs8QXqafNks5sH861gaJpZM4OFYaP> .

Stéphane HULARD · Answer 4 · Tue Jun 27 2017 15:57:50 GMT+0800 (China Standard Time)

Ok so I'll try to submit a PR before the end of the week 😄.

Marco Pivetta · Answer 5 · Sun Jul 23 2017 15:36:07 GMT+0800 (China Standard Time)

Handled in #112