zendesk / radar

High level API and backend for writing web apps that use push messaging

Home Page:http://radar.zendesk.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Radar does not unsubscribe from resources in redis

vanchi-zendesk opened this issue · comments

Radar server keeps subscribing to new resources it is interested in. However, it never tracks when a resource is no longer needed and never unsubscribe from it in redis. This will cause performance issues after several days after seeing several resources later.

Hey Vanchi,
It looks like the code is unsubscribing here and here when all clients have unsubscribed.

It also looks like the server cleans behind a client when it disconnects.

You are right. I think I was not looking at this too closely.