Slight blitting problem in Hyper Street Fighter II (Capcom CPS-2)

[voodoo84]

Hello,

When running Hyper Street Fighter II (Asia 040202, but probably in other variants), on character selection screen, there are problems when blitting character's transparent color on top of the background, as seen in the picture. It manifests more or less for almost all characters.

Thanks for looking into this!

[zelurker]

Nice finding but I have not done anything on the cps2 driver for years and it's not really fresh in my memory, all I remember is that the video rendering part is quite complex... I don't say it can't be fixed, maybe one day where I get extremely motivated, but not now for sure. I'll keep the info anyʍay, This display glitch is in the japan version too.

[voodoo84]

Thanks for the reply!

If it helps, I also tested with Super Street Fighter II Turbo, which has the same character select screen because HSF2 is essentially a pimped-up version of SSF2T. In SSF2T, this bug doesn't show up.

[zelurker]

super street fighter 2 turbo is cps1 which doesn't use any priority bitmap. I never liked these priority bitmaps ! Le dim. 14 mars 2021 à 12:23, voodoo84 ***@***.***> a écrit :

…

Thanks for the reply! If it helps, I also tested with Super Street Fighter II Turbo, which has the same character select screen because HSF2 is essentially a pimped-up version of SSF2T. In SSF2T, this bug doesn't show up. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAV3SD3TFDUARPNEMEXDPBLTDSMEZANCNFSM4ZEWVEBA> .

[voodoo84]

Are you sure? Wikipedia lists regular Street Fighter II Turbo as CPS-1 game, but all Super Street Fighters II (including Turbo and Hyper) are CPS-2.

[zelurker]

if only, you can get the info in the "about" section if you installed history.dat otherwise : ./raine -lsf hsf2j RAINE (680x0 Arcade Emulation) 0.91.13 (c)1998-2020(!) Raine Team CPU: AMD Ryzen 7 2700 Eight-Core Processor game ( name hsf2j description "Hyper Street Fighter 2: The Anniversary Edition (Japan 031222)" manufacturer "Capcom" source file : source/games/cps2drv.c ) source file being cps2drv it's a cps2 game. Le dim. 14 mars 2021 à 14:10, voodoo84 ***@***.***> a écrit :

…

Are you sure? Wikipedia lists regular Street Fighter II Turbo as CPS-1 game, but all *Super* Street Fighters II (including Turbo and Hyper) are CPS-1. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAV3SD5WQBJVSWW7H6WMZ4DTDSYURANCNFSM4ZEWVEBA> .

[voodoo84]

Yes, sorry, I edited the post right after I wrote it, I'm aware that HSF2 is CPS-2, but SSF2T (which has the same character selection screen as HSF2) is also CPS-2 but it doesn't show the blitting bug.
Again, I'm talking about Super Street Fighter II Turbo, not regular Street Fighter II Turbo (which is indeed CPS-1 game).

[zelurker]

Yeah my bad too for super street fighter 2 which is cps2, but anyway a cps2 game which hasn't got the bug just means it was programmed differently, it doesn't help the one having the bug. It would have been much easier to fix for cps1 for sure ! Oh well... ! Le dim. 14 mars 2021 à 17:20, voodoo84 ***@***.***> a écrit :

…

Yes, sorry, I edited the post right after I wrote it, I'm aware that HSF2 is CPS-2, but *S*SF2T (which has the same character selection screen as HSF2) is also CPS-2 but it doesn't show the blitting bug. Again, I'm talking about *Super* Street Fighter II Turbo, not regular Street Fighter II Turbo (which is indeed CPS-1 game). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAV3SD4CPBAMDMXJVROA7SDTDTO6JANCNFSM4ZEWVEBA> .

[voodoo84]

Just one more thing and I'll stop bugging you :)

I did some more testing and the same issue does appear in SSF2T, but in the fight preparation screen instead of character selection screen. Hopefully this will be useful in the future.

[zelurker]

You got me curious enough to try to fix this, because as it could be seen, it had nothing to do with the priorities themselves, it was rather a problem with the transparency. So it was finally a super old bug in a low level drawing function (pdr'aw) when the sprite was flipped horizontally ! It's fixed in git, do you compile from git ? If not I guess I can release a new binary, it's not everyday that such a super old bug is found (it's more than 10 years old here !). Le dim. 14 mars 2021 à 19:06, voodoo84 ***@***.***> a écrit :

…

Just one more thing and I'll stop bugging you :) I did some more testing and the same issue does appear in SSF2T, but in the fight preparation screen instead of character selection screen. Hopefully this will be useful in the future. [image: ssf2t] <https://user-images.githubusercontent.com/14997945/111078952-286e3880-84f8-11eb-9a43-eaf533287caf.jpg> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAV3SD5KHJFAK3RZQDNGN6LTDT3IXANCNFSM4ZEWVEBA> .

[voodoo84]

Thank you very much!
Please publish a new binary when you have time, I'm on Windows and I have no idea which version of mingw64 and libraries to use to compile Raine.

[zelurker]

Binary released, issue closed, thanks for the report !