zelon88 / HRConvert2

A self-hosted, drag-and-drop & nosql file conversion server & share tool that supports 445 file formats in 13 languages.

Home Page:https://github.com/zelon88/HRConvert2

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some typos in sanitizeCore.php

robre opened this issue · comments

commented

I noticed that there are some typos in sanitizeCore.php - I am too lazy to create a pull request.
line 96 - 'sstr_replace' and 'tr_replace' are used instead of 'str_replace'
also I suspect in line 95 maybe you meant filestodownload instead of upload?

best regards

You are absolutely correct! I'm sorry for these mistakes and I appreciate you bringing my attention to them. I am away from my desk at the moment, but I've fixed the code in question in commit 8e67e32. Specifically lines 95 & 96 of sanitizeCore.php. I will make time in the very near future to do a thorough review of this code. Thanks again.

Because you took the time to report an issue (and a very concise correction for it), and in accordance with the HonestRepair Alternative Licensing Policy; please enjoy a BSD 3-Clause License for HRConvert2 for life. Thanks for contributing to HonestRepair open-source software!

I'll leave this issue open for a couple days as a reference for other users.