zegl / kube-score

Kubernetes object analysis with recommendations for improved reliability and security. kube-score actively prevents downtime and bugs in your Kubernetes YAML and Charts. Static code analysis for Kubernetes.

Home Page:https://kube-score.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature request: Support Argo Rollouts

zidadrtl opened this issue · comments

Would be nice to support Argo Rollouts CRD's as deployment type (now this is not recognized as a valid target reference):

For example:

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  name: my-service
spec:
  strategy:
    canary:
      analysis:
        templates:
          - templateName: build-low-error-low-latency
        args:
          - name: service
            value: my-service
          - name: namespace
            value: my-namespace
          - name: build
            value: $(BUILD)
        startingStep: 1
      steps:
        - setWeight: 100
        - pause: {duration: 10m}

@kmarteaux did not know about that, will try it, many thanks!

Argo Rollouts has validation rule built in -- see to the same program written by me I have tried my level bes to solve the query

The problem is not resolved by the fact that argo has its own linter. The problem is that kube-score gives these false negatives:

    [CRITICAL] Service Targets Pod
        · The services selector does not match any pods

I suppose that's because it doesn't check these selectors against the argo rollout pod template labels?

The services selector does not match any pods

we're experiencing the same problem. would be cool to have this. I don't know anything about the implementation of kube-score itself, so helping is hard. but testing is no problem for sure.