ZapierPromise does not use scoped prototype functionality
codebycaleb opened this issue · comments
Bug Description
ZapierPromise does not adhere to bluebird's scoped prototypes recommendations regarding requireing bluebird.
Reproduction Steps
- Create an app that uses bluebird for promises
- Create a Zap using the app and test it via the editor
Errors will be logged that cite bluebird's documentation about not invoking the Promise constructor directly.
The code should work without errors.
Version Info
- Version info: core: 11.2.0
- App id: 154066
@codebycaleb do you have a screenshot of how dire the error messages look? Trying to gauge severity here. And does this only affect CLI apps which separately use bluebird promises? If so, seems fairly narrow. We were just talking about pulling the bluebird stuff out, but it's esoteric and working just fine, so we're hesitant to touch it if we can avoid it.
Yep! It's not mine though. 😅 Here's an obfuscated version:
And does this only affect CLI apps which separately use bluebird promises?
Yeah I think so! This app had a dependency for bluebird@^3.7.2. Definitely agreed on the narrow point - this is the first report I've ever seen and as far as I know this has essentially always been the case. :)
ok, cool! Good to know.
Yeah, it's the first I've heard of it too. We'll keep this open in case other people have the same issue, but it doesn't strike me as a priority.
Just noting I have very similar symptoms but I am not using bluebird in my app directly, it's just imported as a dependency of zapier-platform-core
adpulse.io@1.0.0 /Users/dpovey/src/ppcsamurai/zapier-adpulse.io
└─┬ zapier-platform-core@11.2.0
└── bluebird@3.7.2
When I try to test my Zap I get about 20% of the time the error:
And then when activating my Zap about a similar percentage:
