`skipThrowForStatus` overrides oauth2 `autoRefresh`

Question

`skipThrowForStatus` overrides oauth2 `autoRefresh`

sillypirate opened this issue 3 years ago · comments

Bug Description

Whenever you have skipThrowForStatus: true, it supersedes the autoRefresh: true option in oauth2 setup, forcing developers to include a z.errors.RefreshAuthError() in their afterResponse middleware that autoRefresh: true should be handling.

Reproduction Steps

Set both skipThrowForStatus and autoRefresh to true. The autoRefresh will be ignored.

Version Info

Version info: 10.0.0+
Operating System:
App id: 68700

I am Zap · Answer 1 · Wed Aug 11 2021 05:54:17 GMT+0800 (China Standard Time)

This issue has been copied into our private issue tracker (as PDE-2624). Thanks for the report! We'll update this as we learn more.

David Brownman · Answer 2 · Wed Aug 11 2021 05:54:37 GMT+0800 (China Standard Time)

Thanks @sillypirate! definitely seems like a bug; I'll take a look.