Bogus usage of set()
avaczi opened this issue · comments
In https://github.com/zalando-zmon/zmon-agent-core/blob/master/zmon_agent/discovery/kubernetes/cluster.py#L49, the following:
SKIPPED_ANNOTATIONS = set(('kubernetes.io/created-by'))
This results in
{'-',
'.',
'/',
'a',
'b',
'c',
'd',
'e',
'i',
'k',
'n',
'o',
'r',
's',
't',
'u',
'y'}
I think this is not exactly the intended usage at https://github.com/zalando-zmon/zmon-agent-core/blob/master/zmon_agent/discovery/kubernetes/cluster.py#L216