Giters

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way

Home Page:https://pypi.python.org/pypi/stups-senza

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

special characters within parameters are made html safe

imduffy15 opened this issue · comments

commented

Mustache appears to be doing some escaping on parameters by default.

The following was passed as a parameter:

jdbc:postgresql://localhost:5432/database?ssl=true&sslfactory=org.postgresql.ssl.NonValidatingFactory

It was then used as an environment variable:

TaupageConfig:
    environment:
        JDBC_URL: "{{Arguments.jdbcUrl}}"

In the instance userdata script the following was seen:

jdbc:postgresql://localhost:5432/database?ssl=true&sslfactory=org.postgresql.ssl.NonValidatingFactory

Note the & which resulted in the application failing to deploy.

Workaround for now, was to use JDBC_URL: "{{{Arguments.jdbcUrl}}}" as the environment variable not the three braces instead of two. Didn't see this workaround documented anywhere.

commented

@imduffy15 yes, I was aware of this problem, but I never ran into it (never passed something with "&" as parameter). Feel free to open a PR here or in stups-docs to document the workaround.