Giters

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way

Home Page:https://pypi.python.org/pypi/stups-senza

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Stacks with a weight of 0 are shown as receiving 0% traffic

musiKk opened this issue · comments

commented

We currently have some stacks where all aliases in Route 53 have 0. I don't know how this happened and that is a different problem anyway. However, senza traffic lists all stacks with 0% traffic when in fact they all receive an equal amount of traffic. So for example if one stack has two versions and both have a DNS weight of 0 then senza should say 50% for both.

I think the issue is here but I'm not sure. It seems all stacks with a weight of 0 are filtered out which misses the corner case of all stacks having a 0.

This is probably (i.e. haven't tested it) also a problem for the traffic detection of senza delete which only checks for a Route 53 weight greater than zero. While I'm not mindlessly going around deleting stacks, I'm relying on this feature as a safeguard.