Workarounds to make leaflet-lasso work with touch devices (with Leaflet version 1.6.0 and above)

Question

Workarounds to make leaflet-lasso work with touch devices (with Leaflet version 1.6.0 and above)

bucherc opened this issue 4 years ago · comments

bucherc commented 4 years ago

Hello,

There is a closed issue:
#27

where you added support for touch devices by adding touch events to the map container (thank you!)

This works great with leaflet version 1.5.1 (your demo link uses this version of leaflet)

Unfortunately when you uptick the version of leaflet to anything above 1.5.1 the touch events no longer work on mobile / tablet touchscreen devices

Here is the change log for leaflet:
https://github.com/Leaflet/Leaflet/blob/master/CHANGELOG.md

Would you be able to point me in the right direction to resolve this as we are using Leaflet 1.7.1 and can not go down to version 1.5.1.

Any help would be greatly appreciated.

Thanks,
-Chris Bucher

Jan Žák · Answer 1 · Mon Feb 15 2021 14:04:48 GMT+0800 (China Standard Time)

Thanks @bucherc for the report! I found out that it's caused by Leaflet simulating touch events with mouse events. Since leaflet-lasso handles touch events explicitly, it seems safe to ignore these simulated events. Could you test just released 2.2.4?

bucherc · Answer 2 · Mon Feb 15 2021 14:10:35 GMT+0800 (China Standard Time)

Hello! You are fast! I just tested it and it works perfectly. The lasso control is really amazing as it gets me an array of objects that I can sort through for all layers. Much easier than drawing squares or polygons in my opinion. Here is a screenshot of your lasso in what I'm creating. Appreciate all your work with this! Have a great day! [image: lasso_shot.jpg] Thanks, Chris Bucher

…

On Sun, Feb 14, 2021 at 10:05 PM Jan Žák ***@***.***> wrote: Thanks @bucherc <https://github.com/bucherc> for the report! I found out that it's caused by Leaflet simulating touch events with mouse events. Since leaflet-lasso handles touch events explicitly, it seems safe to ignore these simulated events. Could you test just released 2.2.4? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2XREI5L57OJ2O7BI6GCCDS7C2RHANCNFSM4XTROK6Q> .

Jan Žák · Answer 3 · Mon Feb 15 2021 14:14:55 GMT+0800 (China Standard Time)

The screenshot didn't come through :)

bucherc · Answer 4 · Mon Feb 15 2021 14:16:52 GMT+0800 (China Standard Time)

bucherc commented 4 years ago

Jan Žák · Answer 5 · Mon Feb 15 2021 16:05:56 GMT+0800 (China Standard Time)

Looks good! I worked on a similar water system map in past as well.