z0r0z / helios

Token-based Exchange

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

potentially unsafe multicall

stevennevins opened this issue · comments

linking this discussion on use of msg.value in payable functions and multicall

commented

thanks @stevennevins This seems like a good fix. The only benefit of having multi-call payable is gas-optimization by avoiding redundant check in solidity. Will remove payable keyword as it's not worth it, and this contract will hold LP ETH.