z0r0z / helios

Token-based Exchange

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

safe mint reverts

stevennevins opened this issue · comments

Pretty sure there is an issue with the _mint revert conditions, and the safeTransfer and batch methods probably have the same problem. I converted the repo to foundry and had an issue minting to an EOA (which didn't seem to be an issue when I initially ran the test as a hardhat repo). Converting the if/revert condition to the require statement from solmate made the method work as expected.

commented

great catch @stevennevins I have fixed this issue, as the safety checks were not proper in _mint