Error: Not found

Question

Error: Not found

onel0p3z opened this issue 3 years ago · comments

Thank you for this nice action! I'm trying to use it but I'm getting the following error:

I've verified and confirmed that the secret is available to use in the action. Can you please share any tips or point me in the right direction to solve this issue? Thank you!!

Ahmed · Answer 1 · Thu Mar 25 2021 08:51:57 GMT+0800 (China Standard Time)

Hey. Thanks for reporting this!

Can you please share any tips or point me in the right direction to solve this issue?

My first guess would be that one of the dependencies declared on the issue (or PR) #292 is:

not valid or
inaccessible by the action due to permissions

In both cases, GitHub returns 404 - Not found error. Is possible to share the description of #292? I'm mainly concerned about the point where you declare the dependencies. If all dependencies are local (as in they all belong to the same repo) then my guess is wrong.

Juan Lopez · Answer 2 · Thu Mar 25 2021 11:20:46 GMT+0800 (China Standard Time)

Thanks for the quick response! #292 is a PR in the same repo that uses the action. Would this error be consistent with a PR that was merged and no longer open? I'll try again with another and/or issue. Again, thanks for taking the time to look into this!

Ahmed · Answer 3 · Thu Mar 25 2021 20:55:42 GMT+0800 (China Standard Time)

Thanks for the quick response! #292 is a PR in the same repo that uses the action.

Yeah, that part is clear and most likely not the issue. What I'm interested in is the description of that PR @onel0p3z

If it has something like:

depends on user/another-repo#123

Then my guess is that the provided token is not sufficient to read issues of user/another-repo.

Would this error be consistent with a PR that was merged and no longer open?

No. Closing a dependency shouldn't cause any problem.

Ahmed · Answer 4 · Thu Mar 25 2021 21:38:38 GMT+0800 (China Standard Time)

Is that a public repo I can look at?

Juan Lopez · Answer 5 · Fri Mar 26 2021 05:22:18 GMT+0800 (China Standard Time)

@z0al it's not on a public repo. I'll try to add the action to another repo that's public within the same org and see if I can recreate the issue there. Thank you!

Juan Lopez · Answer 6 · Tue Apr 06 2021 20:50:05 GMT+0800 (China Standard Time)

Hi @z0al. Sorry for the delay. I just realized that the error is thrown whenever a PR is created and the action runs for that PR. Not sure if it's a configuration error on my side or if the action throws whenever it runs for a PR that doesn't have any keywords or labels. I haven't tried to recreate on a public repo yet. Thanks for keeping this open!

Ahmed · Answer 7 · Wed Apr 07 2021 13:27:01 GMT+0800 (China Standard Time)

Hey. No worries.

Having no keywords shouldn't throw anything really. It just means the PR has no dependencies. The Not found is an API error, the cause can be either a misconfiguration (invalid token permissions) or a bug on the action code that makes it request something it shouldn't.

Ahmed · Answer 8 · Wed Apr 07 2021 13:32:30 GMT+0800 (China Standard Time)

I will try to add more action logs on the upcoming weekend to help us identify the cause now and in future.

Ahmed · Answer 9 · Fri Apr 09 2021 14:55:38 GMT+0800 (China Standard Time)

Hey @onel0p3z . I just updated the action to log the full error stack when possible. Can you try to run it manually again in the original #292 issue and check the log?

Mathias Schwaller · Answer 10 · Mon Apr 26 2021 17:18:33 GMT+0800 (China Standard Time)

Got a similar error when referencing a PR in an other private repository from the same organization:

HttpError: Not Found
    at /home/runner/work/_actions/z0al/dependent-issues/v1/webpack:/dependent-issues/node_modules/@octokit/request/dist-node/index.js:66:1
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Im not sure if it's the same cause as the issue reported by @onel0p3z.

The description of the pull request looks like the following:

Depends on https://github.com/orgname/repository-name/pull/1

The referenced PR is closed an merged.

Thanks in advance for your support

Jacob Pilegaard · Answer 11 · Mon Apr 26 2021 17:46:29 GMT+0800 (China Standard Time)

Got a similar error when referencing a PR in an other private repository from the same organization:
HttpError: Not Found
    at /home/runner/work/_actions/z0al/dependent-issues/v1/webpack:/dependent-issues/node_modules/@octokit/request/dist-node/index.js:66:1
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
Im not sure if it's the same cause as the issue reported by @onel0p3z.

The description of the pull request looks like the following:
Depends on https://github.com/orgname/repository-name/pull/1
The referenced PR is closed an merged.

Thanks in advance for your support

I am having the exact same issue, trying to reference across an organisations repos.

Ahmed · Answer 12 · Mon Apr 26 2021 22:53:21 GMT+0800 (China Standard Time)

Got a similar error when referencing a PR in an other private repository from the same organization:
HttpError: Not Found
    at /home/runner/work/_actions/z0al/dependent-issues/v1/webpack:/dependent-issues/node_modules/@octokit/request/dist-node/index.js:66:1
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Thanks for the report @MathiasSchwaller . That's expected though, I'm assuming you're not using a Personal Access Token (PAT), right?

The solution to your issue is using a PAT with repo scope instead of the auto-generated GITHUB_TOKEN. That's because GITHUB_TOKEN only gives access to the current repo and not the whole org repos.

Ahmed · Answer 13 · Mon Apr 26 2021 22:54:47 GMT+0800 (China Standard Time)

I should probably create a FAQs section in the README later. PRs to improve that are welcome

Mathias Schwaller · Answer 14 · Mon Apr 26 2021 23:33:12 GMT+0800 (China Standard Time)

Got a similar error when referencing a PR in an other private repository from the same organization:
HttpError: Not Found
    at /home/runner/work/_actions/z0al/dependent-issues/v1/webpack:/dependent-issues/node_modules/@octokit/request/dist-node/index.js:66:1
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
Thanks for the report @MathiasSchwaller . That's expected though, I'm assuming you're not using a Personal Access Token (PAT), right?

The solution to your issue is using a PAT with repo scope instead of the auto-generated GITHUB_TOKEN. That's because GITHUB_TOKEN only gives access to the current repo and not the whole org repos.

Thank you for the fast response.

Yes i was using the default GITHUB_TOKEN, but because of security concerns i can't switch to a PAT token with repo access. A PAT with repo:status access ins't sufficient for the action (i'm not that familiar with PATs and the documentation isn't that specific about the different scopes)?

I'm going to create a FAQ for cross-repository-dependencies later in the evening.

Juan Lopez · Answer 15 · Tue Apr 27 2021 05:50:50 GMT+0800 (China Standard Time)

@z0al my issue was definitely the same as @MathiasSchwaller. After updating the token with a PAT, the error went away and the action finished without an issue. Thanks for all the help and patience! I'll go ahead and close this issue. @MathiasSchwaller thanks for adding the FAQ in #109 ❤️

Ahmed · Answer 16 · Tue Apr 27 2021 13:10:15 GMT+0800 (China Standard Time)

A PAT with repo:status access ins't sufficient for the action?

I understand your concern @MathiasSchwaller , but I'm afraid the PAT token scopes are not that flexible. What this Action needs is permission to do the followings:

Update PR commit status (the repo:status should be enough for this part)
Update labels
Write comments

What I'd do in your case is to simply review the code and then fork the repo and run your own fork, which is fairly easy to do. Luckily, there isn't much going on on this repo code-wise so you don't have to update your fork as often (you can safely ignore Dependabot PRs). You could watch "Releases" and update accordingly.

Jacob Pilegaard · Answer 17 · Tue Apr 27 2021 15:48:12 GMT+0800 (China Standard Time)

Hey z0al, I've tried to use a PAT in your action, but I still run into problems, it won't let me access the other repo. I just replaced the "GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN}}" with the PAT. Is this the correct approach?

Thanks!

Ahmed · Answer 18 · Tue Apr 27 2021 16:13:03 GMT+0800 (China Standard Time)

Yeah, that sounds about right @KillWolf, maybe double-check the token has repo scope?. You can also check this guide in the FAQs (thanks to @mathias-schwaller )