Pending Changes commit not showing hooks errors/messages

[Javier Castro]

I dont know if current version 0.9.6.2 is here, or in codeplex...

I've tried the one here..

Anyway, I have a problem with hooks: a standard commit-msg hook, returning an exit code = 1 makes git pending changes tool window work ugly..

You press commit, with a given message, then GitScc.GitBash.Run() is called. this method completely ignores the process ExitCode.

I think somehow the ExitCode should be handled in this case: when it is different to 0, it means there is an error con the commit-msg hook, and also should be nice to show a dialog with all the output comming from the Run() (not spliting the resulting string later:

if (msg.IndexOf('\n') > 0) msg = msg.Split('\n')[0];

Also, Commit() in PendingChangesView is not aware of the error inside tracker.Commit(). May be tracker.Commit() should get not a simple string, but a pair Status,Message (Status could be ExitCode, and Message the plain output) so you can show a dialog with the message when there is an error (ExitCode <> 0)

If u can point me the right repo to make some patches, i can help with this?

Thanks!

[Javier Castro]

Already merged on master