Unit test failures with next version of ggplot2
thomasp85 opened this issue · comments
The unit tests for gghighlight contains some assumptions that the move to linewidth breaks. The best thing is probably to skip them for now and then turn them on again after ggplot2 has been released
══ Failed tests ════════════════════════════════════════════════════════════════
── Failure (test-bleach.R:64:3): bleach_layer() works ──────────────────────────
as.list(x) (`actual`) not equal to as.list(y) (`expected`).
`actual$aes_params` is length 1
`expected$aes_params` is length 2
`names(actual$aes_params)`: "colour"
`names(expected$aes_params)`: "colour" "size"
`actual$aes_params$size` is absent
`expected$aes_params$size` is a double vector (3)
Backtrace:
▆
1. └─gghighlight:::expect_equal_layer(...) at test-bleach.R:64:2
2. └─testthat::expect_equal(as.list(x), as.list(y), ignore_formula_env = TRUE) at tests/testthat/helpers.R:10:2
Thanks. I think I already fixed it in the dev version, but don't remember well. I'll confirm and submit the next version to CRAN soon.
Confirmed the fix. I'll prepare for the next release.