Question about max length of sentence

[xixy]

Thank you very much for your open-sourced code. I noticed that you set the max length of sentence to 40 by cutting sentences longer than 40 as follows:

NBTNGMA4ED/data_utils.py

Line 200 in e5d5445

 class BatchManager(object): 

Is the comparison fair considering many sentences are longer than 40? For example, the longest sentence in train/dev/test contains 228/154/84 tokens respectively. The triggers are also dropped and not counted when calculating F1.

Thank you and look forward to your reply.

[yh]

The parameter of "max length of sentences" is a hyper-parameter, it can be set to 40 or others for batch training. In evaluation, it can be set as the max length of sentences on the development set.

[xixy]

Thanks for reply. Another question is did you use the max length for evaluation, which corresponds to the performance reported in your paper?

[yh]

Yes, we set the hyper-parameter as the max sentence length on the test set for evaluation.

[xixy]

Thanks for reply.