Foreground, entry point, and image tag
geozeke opened this issue · comments
Love the idea of moving docker image building to CI! Thanks, @oliv3r!
I've always built the image locally, and it's worked fine until recent commits. Here are two things I noticed:
- The
README.md
file says to run the docker image fromghcr.io/yrutschle/sslh:latest
, but the image seems to be packaged up asghcr.io/yrutschle/sslh:master
. - It doesn't matter if I clone the repo and manually build the image, or pull it from
ghcr.io/yrutschle/sslh:master
. It seems that the container starts normally, then immediately exits with a status code of0
. If I roll back tof23da1f
, and build manually, all is well. Any commit later thanf23da1f
doesn't seem to work.
Thanks for all the hard work on this!
Sorry about that. This one's on me. I missed that the update requires the --foreground
switch when you run the docker container. Updated the docker compose file and pulled directly from ghrc.io
and all is well.
I think there's still a lingering documentation issue, though. The image that needs to be pulled is ghcr.io/yrutschle/sslh:master
, but the README.md
file says to pull this: ghcr.io/yrutschle/sslh:latest
. If I've got it wrong, which is entirely possible, then recommend closing this issue. I'll just leave it up for now in case it's helpful to someone else.