yonicd / carbonate

carbon.js for R

Home Page:https://yonicd.github.io/carbonate/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing package declaration

LucyMcGowan opened this issue · comments

This is awesome! I love the new ability to add a tinyurl! I was just trying to run it and ran into a problem if I hadn't already loaded the magick package. I believe the problem is this line:

image_write(file.path(path,file))

I think it should be:

magick::image_write(file.path(path,file))

I'm happy to submit a quick PR, or if it would be easier for you to fix that is 👌 too!

I also just realized there may be an issue with this chunk as well if the pipe isn't loaded:

carbonate/R/carbonate.R

Lines 71 to 77 in 33c12fa

img <- img%>%
magick::image_annotate(text = private$tiny(),gravity = self$tinyurl_location)
img%>%
image_write(file.path(path,file))
}

good catches. i thought i ran cmd check (oops). i'll update those. thanks :)

thanks again! 7256fb0