yomotsu / camera-controls

A camera control for three.js, similar to THREE.OrbitControls yet supports smooth transitions and more features.

Home Page:https://yomotsu.github.io/camera-controls/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"setOrbitPoint" will affect the "dollyToCursor" method cannot be maintained.

Innovgame opened this issue · comments

Describe the bug

Hello, I am using camera-controls and want to achieve a function that can always rotate the camera around the origin. Therefore, I used setOrbitPoint. However, I found that the dollyToCursor set during the zoom process became invalid. I am not very familiar with this part of the code and I am not sure if it is a bug. I hope to get your help.

To Reproduce

Steps to reproduce the behavior:

  1. examples/orthographic.html demo
    image
  2. select dollyToCursor
  3. drag
  4. rotate
  5. zoom

Code

No response

Live example

No response

Expected behavior

maintain the effect of dollyToCursor.

Screenshots or Video

bandicam.2023-06-06.10-37-23-333.mp4

Device

Desktop

OS

Windows

Browser

Chrome

Thanks for using camera-controls.
I think that is the known issue, caused by focalOffset

and I can't fix it unfortunately🥲
TBH, I would like to remove setOrbitPoint() and other focalOffset related features...

Thank you for your reply. I have tested it and found that it is indeed related to focalOffset. However, I don't have a good idea on how to solve it yet.

I don't have a good idea on how to solve it yet.

Same here😢

Closing due to lack of feedback.

@yomotsu does it make sense to close this issue since its still not working?

Oh, sorry it was a mistake...
But unfortunately, I have no plan to fix it because focalOffset which is used in setOrbitPoint causes many other problems.
Hope someone could solve it one day...
Reopening the issue.

@yomotsu Yeah I see it's a tricky one. Thanks anyway for all your work!