Error on 2.3.5-p1
Top-CMS opened this issue · comments
Hi,
Unfortunately it won't work with a clean Magento install with demo data for Magento 2.3.5-p1
composer require yireo/magento2-replace-all
Using version ^2.3 for yireo/magento2-replace-all
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Conclusion: don't install yireo/magento2-replace-all 2.3.2
- Conclusion: don't install yireo/magento2-replace-all 2.3.1
- Conclusion: remove magento/product-community-edition 2.3.5-p1
- Conclusion: don't install magento/product-community-edition 2.3.5-p1
- Conclusion: don't install yireo/magento2-replace-all 2.3.5
- Installation request for vertex/sdk (locked at 1.2.2) -> satisfiable by vertex/sdk[1.2.2].
- Installation request for magento/product-community-edition 2.3.5-p1 -> satisfiable by magento/product-community-edition[2.3.5-p1].
- Conclusion: don't install yireo/magento2-replace-all 2.3.4
- magento/product-community-edition 2.3.5-p1 requires yotpo/magento2-module-yotpo-reviews-bundle 3.1.0 -> satisfiable by yotpo/magento2-module-yotpo-reviews-bundle[3.1.0].
- don't install yireo/magento2-replace-all 2.3.3|remove yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- don't install yireo/magento2-replace-all 2.3.3|don't install yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- don't install yireo/magento2-replace-all 2.3.3|don't install yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- Installation request for yireo/magento2-replace-all ^2.3 -> satisfiable by yireo/magento2-replace-all[2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5].
Installation failed, reverting ./composer.json to its original content.
Thanks. But unfortunately, this is already widely covered. Please read the instructions here carefully: https://github.com/yireo/magento2-replace-tools
I can confirm by the way that in my environment this works perfectly fine.
Not @ mine standard m.2.3.5.-p1 with demo data installation
- product-community-edition 2.3.5-p1 with demo data
- ethanyehuda/magento2-cronjobmanager
- honl/magento2-nl-nl
Also tried
If the composer require command does not work for you, try the following:
composer require --no-update yireo/magento2-replace-bundled
composer install
If this fails, try the following:
rm -r vendor/
composer require --no-update yireo/magento2-replace-bundled
composer install
If this fails, try the following:
rm -r vendor/ composer.lock
composer require --no-update yireo/magento2-replace-bundled
composer install
Unfortunately, I'm unable to reproduce this myself, so something else must be in play than just these commands.
I will try this on a new installation 2.3.5 (not 2.3.5-p1 with demo data)
Also with clean install without demo data
composer require yireo/magento2-replace-all
Using version ^2.3 for yireo/magento2-replace-all
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Conclusion: don't install yireo/magento2-replace-all 2.3.2
- Conclusion: don't install yireo/magento2-replace-all 2.3.1
- Conclusion: remove magento/product-community-edition 2.3.5-p1
- Conclusion: don't install magento/product-community-edition 2.3.5-p1
- Conclusion: don't install yireo/magento2-replace-all 2.3.5
- Installation request for vertex/sdk (locked at 1.2.2) -> satisfiable by vertex/sdk[1.2.2].
- Installation request for magento/product-community-edition 2.3.5-p1 -> satisfiable by magento/product-community-edition[2.3.5-p1].
- Conclusion: don't install yireo/magento2-replace-all 2.3.4
- magento/product-community-edition 2.3.5-p1 requires yotpo/magento2-module-yotpo-reviews-bundle 3.1.0 -> satisfiable by yotpo/magento2-module-yotpo-reviews-bundle[3.1.0].
- don't install yireo/magento2-replace-all 2.3.3|remove yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- don't install yireo/magento2-replace-all 2.3.3|don't install yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- don't install yireo/magento2-replace-all 2.3.3|don't install yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- Installation request for yireo/magento2-replace-all ^2.3 -> satisfiable by yireo/magento2-replace-all[2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5].
Installation failed, reverting ./composer.json to its original content.
$ magerun sys:info
Magento System Information
+------------------+-----------------------------------------------------------------------+
| name | value |
+------------------+-----------------------------------------------------------------------+
| Name | Magento |
| Version | 2.3.5-p1 |
| Edition | Community |
| Application Mode | default |
| Session | files |
| Crypt Key | 482b7aa640ed3964a1127733d3371a16 |
| Install Date | Sat, 02 May 2020 15:35:26 +0000 |
| Cache Backend | Cm_Cache_Backend_File |
| Vendors | Magento, MSP, Amazon, Dotdigitalgroup, Klarna, Temando, Vertex, Yotpo |
| Attribute Count | 137 |
| Customer Count | 0 |
| Category Count | 2 |
| Product Count | 0 |
+------------------+-----------------------------------------------------------------------+
@jissereitsma I can reproduce it. It looks like Packagist does not include 2.3.5 version at the moment. The errors are because the latest version downloaded from Packagist is 2.3.4, which is not compatible with Magento 2.3.5-p1.
I believe, that this is because of invalid JSON (composer.json) - one bracket too much. As I'm receiving the following when using the github repo as a source of the package:
Skipped branch magento-2.3.5, "1565da8ecb6d0c526a01c265013ff5f186716992:composer.json" does not contain valid JSON
Parse error on line 210:
...dle": "*" } }}
-------------------^
Expected: 'EOF'
I guess this kind of stupid mistakes (the typo) should be prevented by using some kind of CI system, like GitHub Actions. I'll look into this soon. However, I'm not entirely sure if it is related to the issue above. It could make sense.
Version 2.3.5 of the replace package is there at this moment: https://packagist.org/packages/yireo/magento2-replace-all Or did you refer to another package?
Thanks for the merge. I confirm, that this resolves the issue with not being able to get 2.3.5 from Packagist. The 2.3.5 didn't go to Packagist before the fix, I believe? As it wasn't available when I wrote the earlier comment (the latest was 2.3.4).
The errors still persist. I'm able to get on 2.3.5 when I point it directly via composer:
composer require yireo/magento2-replace-all:2.3.5
Anyways, the errors now are:
Your requirements could not be resolved to an installable set of packages.
Problem 1
- don't install yireo/magento2-replace-all 2.3.5|don't install yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- don't install yireo/magento2-replace-all 2.3.5|don't install yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- Installation request for yireo/magento2-replace-all 2.3.5 -> satisfiable by yireo/magento2-replace-all[2.3.5].
- Installation request for yotpo/magento2-module-yotpo-reviews-bundle (locked at 3.1.0) -> satisfiable by yotpo/magento2-module-yotpo-reviews-bundle[3.1.0].
When I look closely, it seems that Magento uses hard-dependency on yotpo/magento2-module-yotpo-reviews-bundle. But it's strange as I do not see that in the main Magento repo, while it exists in the composer.lock of a fresh composer project create.
So it looks like it's Magento mistake, or there's a change needed in yireo/magento2-replace-bundled package by removing https://github.com/yireo/magento2-replace-bundled/blob/2.3.5/composer.json#L33
@jissereitsma , I'm getting the same problems as @matkowalski reported:
$ composer require yireo/magento2-replace-all:2.3.5
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- don't install yotpo/magento2-module-yotpo-reviews-bundle 3.1.0|don't install yireo/magento2-replace-all 2.3.5
- don't install yireo/magento2-replace-all 2.3.5|remove yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- don't install yireo/magento2-replace-all 2.3.5|don't install yotpo/magento2-module-yotpo-reviews-bundle 3.1.0
- Installation request for yireo/magento2-replace-all 2.3.5 -> satisfiable by yireo/magento2-replace-all[2.3.5].
- Installation request for yotpo/magento2-module-yotpo-reviews-bundle (locked at 3.1.0) -> satisfiable by yotpo/magento2-module-yotpo-reviews-bundle[3.1.0].
Installation failed, reverting ./composer.json to its original content.
Any thoughts?
Unfortunately, a single composer require is NOT equal to troubleshooting this in full. If you are looking for a zero effort way of reducing the Magento 2.3 packages, please wait for later Magento versions like 2.4+. If you are willing to troubleshoot this, please see all suggestions here: https://github.com/yireo/magento2-replace-tools If I follow all instructions there, I do not get the same results.