yiisoft / yii-debug-frontend

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

bootstrap4

andrtechno opened this issue · comments

обновление будет под yiisoft/yii2-bootstrap4 ?

И вообще, было бы не плохо выпустить все на bootstrap4

debug toolbar should not depend on a bootstrap version installed via composer, it can bundle it's own bootstrap to avoid dependecy conflicts with applications using other bootstrap versions.

commented

@cebe Then it would be nice to display the debug panel in the iframe
then it will not conflict with the styles and js code of the main application

Its styles are isolated by very specific class name and using CSS cascade so should not affect anything on the website itself. That's battle-tested.

commented

@samdark Немного наоборот ))
Я имел в виду стили сайта может немного коверкать yii-debug панель.

В данном случае @cebe предполагает случай одновременного использования bootstrap 4 для сайта и bootstrap 3 для yii-debug панели.

Toolbar isn't using bootstrap at all: https://github.com/yiisoft/yii-debug/blob/master/src/assets/toolbar.css. Bootstrap is used for debugger itself.

The problem here is w/ the debugger and possible dependency conflict, not w/ toolbar.

Closing since the issue isn't up to date with current code/approach.