Standard `tests/bootstrap.php`

Question

Standard `tests/bootstrap.php`

hiqsol opened this issue 6 years ago · comments

We have exactly identical tests/bootstrap.php in all the packages.
So we could create the standard one, put it into yii-core and require in other packages.
What do you think?

Andrii Vasyliev · Answer 1 · Mon Dec 31 2018 02:03:56 GMT+0800 (China Standard Time)

Not really in all the packages, but we could use the same tests/bootstrap.php and we should.

Alexander Makarov · Answer 2 · Mon Dec 31 2018 02:11:54 GMT+0800 (China Standard Time)

Good idea.

Mehdi Achour · Answer 3 · Mon Dec 31 2018 02:15:24 GMT+0800 (China Standard Time)

You've read my mind :)

Andrii Vasyliev · Answer 4 · Mon Dec 31 2018 02:53:20 GMT+0800 (China Standard Time)

Used in yii-captcha
yiisoft/yii-captcha@ae925af

Mehdi Achour · Answer 5 · Wed Jan 02 2019 17:12:02 GMT+0800 (China Standard Time)

Reopening so we remember to spread this change

Mehdi Achour · Answer 6 · Thu Jan 03 2019 16:48:38 GMT+0800 (China Standard Time)

We also might want to document this.
5bb60b4#r31827488

Alexander Makarov · Answer 7 · Sun Apr 14 2019 18:05:04 GMT+0800 (China Standard Time)

I don't like it:

It's implicit.
There are extra dependencies.
Duplication eliminated is tiny.