bloom filter crash in ironwood causes yggdrasil to panic (was "panic: this should never happen")
temtemy opened this issue · comments
Been getting this crash after I upgraded to 0.5.3. Seems related to #1100 but weirdly I never got that crash in 0.5.2.
panic: this should never happen
goroutine 83733 [running]:
github.com/Arceliar/ironwood/network.(*bloom).encode(0xc000014c48, {0xc000571000, 0x3, 0x40be})
/home/mima/go/pkg/mod/github.com/!arceliar/ironwood@v0.0.0-20231126105342-ad38416a77c8/network/bloomfilter.go:78 +0x345
github.com/Arceliar/ironwood/network.wireEncode({0xc000571000?, 0xc000025098?, 0x61f0b1e857313?}, 0x0?, {0x9a5770?, 0xc000014c48?})
/home/mima/go/pkg/mod/github.com/!arceliar/ironwood@v0.0.0-20231126105342-ad38416a77c8/network/wire.go:65 +0x75
github.com/Arceliar/ironwood/network.(*peerWriter).sendPacket.func1()
/home/mima/go/pkg/mod/github.com/!arceliar/ironwood@v0.0.0-20231126105342-ad38416a77c8/network/peers.go:207 +0x1bc
github.com/Arceliar/phony.(*Inbox).run(0xc0000c0c18)
/home/mima/go/pkg/mod/github.com/!arceliar/phony@v0.0.0-20220903101357-530938a4b13d/actor.go:98 +0x33
created by github.com/Arceliar/phony.(*Inbox).restart
/home/mima/go/pkg/mod/github.com/!arceliar/phony@v0.0.0-20220903101357-530938a4b13d/actor.go:132 +0x56
I see massive disconnects of peers. Also my node crashed.
Probably it is better for operators to revert to 0.5.2-0002 until fresh bug is fixed.
Downgrading probably won't help, as this is code that hasn't changed since v0.5.0.
I've uploaded yggdrasil-develop version 0.5.3-1-g741f825 to my S3 Debian repo, please test if you can & let me know if it helps.
Downgrading probably won't help, as this is code that hasn't changed since v0.5.0.
Looks like you are right, my reverted node also crashed.
But it is very strange - I saw no crashes for a long time with 0.5.2-0002.
0.5.3-1-g741f825
I will test it.
No crash for 1.5 hours with 0.5.3-1-g741f825.
Also frequent reconnects stopped, approximately 1 hour ago.
No crashes as well for 10+ hours after upgrading to 0.5.4. Closing
Resolving commits are 465b82d (Arceliar/ironwood) and 741f825 for future reference