[Question/Possible bug] Is it intended not to support Nullable<DateTime> in PropertyMap?

[Maciej Chyczewski]

Sorry if I'm asking a dumb question here. I have no broad picture of the project's implementation.

I found an anomaly in this method. All struct types are supported together with their Nullable representations. The only exception is DateTime - DateTime? is not supported.
Is it intended?

Code currently exists here:

Streamstone/Source/Streamstone/PropertyMap.cs

Lines 103 to 133 in 08f59f6

 static EntityProperty ToEntityProperty(string key, object value, Type type) 
 { 
     if (type == typeof(byte[])) 
         return new EntityProperty((byte[])value); 
  
     if (type == typeof(bool) || type == typeof(bool?)) 
         return new EntityProperty((bool?)value); 
  
     if (type == typeof(DateTimeOffset) || type == typeof(DateTimeOffset?)) 
         return new EntityProperty((DateTimeOffset?)value); 
  
     if (type == typeof(DateTime)) 
         return new EntityProperty((DateTime?)value); 
  
     if (type == typeof(double) || type == typeof(double?)) 
         return new EntityProperty((double?)value); 
  
     if (type == typeof(Guid) || type == typeof(Guid?)) 
         return new EntityProperty((Guid?)value); 
  
     if (type == typeof(int) || type == typeof(int?)) 
         return new EntityProperty((int?)value); 
  
     if (type == typeof(long) || type == typeof(long?)) 
         return new EntityProperty((long?)value); 
  
     if (type == typeof(string)) 
         return new EntityProperty((string)value); 
  
     throw new NotSupportedException("Not supported entity property type '" + value.GetType() + "' for '" + key + "'"); 
 } 

Code was originally introduced here:

Streamstone/Source/Streamstone/Extensions.cs

Lines 79 to 109 in 407b194

 static EntityProperty ToEntityProperty(string key, object value, Type type) 
 { 
     if (type == typeof(byte[]))  
         return new EntityProperty((byte[])value); 
      
     if (type == typeof(bool) || type == typeof(bool?))  
         return new EntityProperty((bool?)value); 
      
     if (type == typeof(DateTimeOffset) || type == typeof(DateTimeOffset?))  
         return new EntityProperty((DateTimeOffset?)value); 
      
     if (type == typeof(DateTime))  
         return new EntityProperty((DateTime?)value); 
  
     if (type == typeof(double) || type == typeof(double?))  
         return new EntityProperty((double?)value); 
  
     if (type == typeof(Guid) || type == typeof(Guid?))  
         return new EntityProperty((Guid?)value); 
  
     if (type == typeof(int) || type == typeof(int?))  
         return new EntityProperty((int?)value); 
  
     if (type == typeof(long) || type == typeof(long?))  
         return new EntityProperty((long?)value); 
      
     if (type == typeof(string))  
         return new EntityProperty((string)value); 
      
     throw new NotSupportedException("Not supported entity property type '" + value.GetType() + "' for '" + key + "'"); 
 } 

[Yevhen Bobrov]

Looks like a bug. Don't think there any reason why it was omitted.

[Yevhen Bobrov]

Done!