Snapshot verification fails on Windows
wezm opened this issue · comments
Wesley Moore commented
---- tests\fail\elaboration\unification\mismatch\arrow-both.fathom ----
snapshot mismatch:
---- path ----
tests\fail\elaboration\unification\mismatch\arrow-both.snap
---- stderr diff ----
2| - ┌─ tests/fail/elaboration/unification/mismatch/arrow-both.fathom:3:34
2| + ┌─ tests\fail\elaboration\unification\mismatch\arrow-both.fathom:3:34
8| - ┌─ tests/fail/elaboration/unification/mismatch/arrow-both.fathom:3:39
8| + ┌─ tests\fail\elaboration\unification\mismatch\arrow-both.fathom:3:39
failures:
snapshot mismatch
Paths in errors use the native format, thus Windows ones do not match.
Brendan Zabarauskas commented
Hmm, I wonder how other compilers handle this in their tests. 🤔
Wesley Moore commented
rustc tests appear to assume unix-style paths and line endings:
https://github.com/rust-lang/rust/blob/master/src/test/ui/module-macro_use-arguments.stderr
and are normalised as such in the test runner:
Brendan Zabarauskas commented
Oh cool! I was looking in compiletest
but missed this!