Prompt to download new version, even though it is installed
jimbo1jimbo opened this issue · comments
jimbo1jimbo commented
I have downloaded and installed AudioBookConverter-All-Users-6.2.10.msi (not via Steam)
Even though I have the latest version, when I start the program, I get a prompt to download the new version.
Is there a workaround to stop the check?
sgmoore commented
Same happens here.
I think this is a case-sensitivity issue. It is comparing the contents of https://raw.githubusercontent.com/yermak/AudioBookConverter/version/windows.txt which is
AudiobookConverter-6.2.10 but the program version is actually
AudioBookConverter-6.2.10
jjones3905 commented
Yep.
Code from AudiobookConverter.java, lines 174-5
String version = readStringFromURL("https://raw.githubusercontent.com/yermak/AudioBookConverter/version/" + platform + ".txt");
if (!Version.getVersionString().equals(StringUtils.trim(version))) {
and from Version.java
public static String getVersionString() {
return "AudioBookConverter-#{APP_VERSION}#";
}
Yarick Yermak commented
This is not a bug :)
jjones3905 commented
Clever, just getting rid of the alphas in the version so case
sensitivity doesn't intrude :)
…On Thu, May 30, 2024 at 6:53 AM Yarick Yermak ***@***.***> wrote:
This is not a bug :)
—
Reply to this email directly, view it on GitHub
<#525 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AED27QODCRWNEXGITM37XF3ZE4HKNAVCNFSM6AAAAAA74SQ6RWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZZGM4DSNZRGM>
.
You are receiving this because you commented.Message ID:
***@***.***>