Build is broken
ruyadorno opened this issue · comments
While working on #95 I found out that npm run build is not really working as expected. To make sure it wasn't a problem with the electron related updates I went on and tested on master and got the same results.
@stefanbuck do you believe you might have some time to take a look? 👀
Mhhh that's strange. The build was successful and the app is executable. Can you provide more details what exactly is not working for you?
On current master:
npm run build
> yeoman-app@0.0.0 build /Users/ruy.adorno/Documents/workspace/yeoman-app
> electron-compile --target ./cache src/ static/ && node scripts/build.js
Packaging app for platform darwin x64 using electron v0.33.7
Build task completed.
open build/darwin/x64/Yeoman-darwin-x64/Yeoman.app
This is what I get:
I was able to build the app from current master on all my computers. Can you please verify this again, just to be sure?
Did you delete .cache and node_modules folder upfront?
it seems my issues were either related to not cleaning the .cache folder or related to the existence of an apm folder that was present in the project root - probably a leftover from old configs
anyways, a clean start fixed it, thanks @stefanbuck