[Inquiry] Why was babel removed?

Question

[Inquiry] Why was babel removed?

mfunkie opened this issue 9 years ago · comments

I noticed in this changeset from May that Babel was removed as a dependency:

7abf463

Per http://facebook.github.io/react/blog/2015/06/12/deprecating-jstransform-and-react-tools.html
the React JSTransform is being deprecated, which is what node-jsx uses to transform code.

Sindre Sorhus · Answer 1 · Sun Jul 26 2015 23:46:04 GMT+0800 (China Standard Time)

Can't answer why it was removed, but we should just use electron-precompile and use ES2015 for everything.

Mark Funk · Answer 2 · Mon Jul 27 2015 00:18:34 GMT+0800 (China Standard Time)

Sounds good to me. I can look at adding it over the next few days if no one objects or gets to it first.

Sindre Sorhus · Answer 3 · Mon Jul 27 2015 00:35:02 GMT+0800 (China Standard Time)

@ruyadorno @stefanbuck You good with that?

Stefan Buck · Answer 4 · Mon Jul 27 2015 06:03:13 GMT+0800 (China Standard Time)

I'm totally fine with it. I removed babel, because we didn't used any ES2015 feature at this point. But you are right, we should definitely start writing ES2015 coe.

@mfunkie a PR is always welcome 👍

Ruy Adorno · Answer 5 · Wed Jul 29 2015 01:46:31 GMT+0800 (China Standard Time)

just for the record, I also completely agree 👍

@mfunkie's PR is on the way so I'm closing this one, thanks!