Proposal: Drop minsafe option and templates
eddiemonge opened this issue · comments
Since the project is built using ngmin in grunt, does it make sense to still have min-safe and minsafe templates? They add complexity to the code and if removed would make maintaining and testing easier.
👍
@btford @passy @sindresorhus thoughts?
From what I can remember they're there because ngmin was quite unstable. Not sure if that still applies.
I would love to rip that out if no one has an objection. Granted, if people rely on minsafe because they created a project not using ngmin then the generator no longer will work for them. But for those people, updating to use ngmin could be a documentation update issue. Really, who wants to write all their code like ['name', function(name){}]. Ugh so ugly. Let it be done in the background.
+1
Even though ngmin has some edge cases it doesn't cover at the moment, you can still manually work around them. The minsafe branch complicates the code a lot and is a big maintenance burden that very few people actually benefit from.
as addicted user of generator-angular, I ask you to not make me type additional option each time.
I thought programming is (also) about automation of repeating actions, so it would be "un-automation".
I'm personally for removing it.
@Jamm This would be getting rid of something that requires you to type additional stuff and automates it for you.
Deprecate in the next point release and remove in the one after that then? Any opposed?
sgtm
On Dec 5, 2013 4:42 PM, "Eddie Monge" notifications@github.com wrote:
@Jamm https://github.com/jamm This would be getting rid of something
that requires you to type additional stuff and automates it for you.Deprecate in the next point release and remove in the one after that then?
Any opposed?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/452#issuecomment-29913915
.
👏