Bug: Strat solidexJoint not matching in group

Question

Bug: Strat solidexJoint not matching in group

storming0x opened this issue 3 years ago · comments

This strat has the name Strategy_ProviderOfUSDCToNoHedgeSolidexJoint,

https://yearn.watch/network/fantom/vault/0xEF0210eB96c7EB36AF8ed1c20306462764935607/strategy/0x80332ecdc7ccdb187b95c97d4b33a8e918f8dd70

the group created here is not matching it https://github.com/yearn/yearn-watch/pull/246/files

Yao · Answer 1 · Wed Mar 23 2022 03:49:00 GMT+0800 (China Standard Time)

If I understand correctly, we simply need to change Solidex Joint in line 742 of risk-framework.json to Strategy_ProviderOfUSDCToNoHedgeSolidexJoint? And I don't think this strategy is active for the Ethereum network so I don't need to change the label in line 550 for now?

p.s. I am not sure how to derive the nameLike value.

borrito · Answer 2 · Wed Mar 23 2022 04:07:48 GMT+0800 (China Standard Time)

If I understand correctly, we simply need to change Solidex Joint in line 742 of risk-framework.json to Strategy_ProviderOfUSDCToNoHedgeSolidexJoint? And I don't think this strategy is active for the Ethereum network so I don't need to change the label in line 550 for now?

For me, it seems like the issue was mainly concerning the one on Fantom, and it should be handled by now (after the merge in f899952)
I think the implementation in risk-framework.json file was fine, the mismatch of data in SDK and the helper contract seemed to be the problem atm

Yao · Answer 3 · Wed Mar 23 2022 04:36:35 GMT+0800 (China Standard Time)

If I understand correctly, we simply need to change Solidex Joint in line 742 of risk-framework.json to Strategy_ProviderOfUSDCToNoHedgeSolidexJoint? And I don't think this strategy is active for the Ethereum network so I don't need to change the label in line 550 for now?

For me, it seems like the issue was mainly concerning the one on Fantom, and it should be handled by now (after the merge in f899952) I think the implementation in risk-framework.json file was fine, the mismatch of data in SDK and the helper contract seemed to be the problem atm

Can you elaborate on what and where the SDK and the helper contract are? I am new to Yearn, sorry if the questions are silly :p

borrito · Answer 4 · Wed Mar 23 2022 04:42:54 GMT+0800 (China Standard Time)

Can you elaborate on what and where the SDK and the helper contract are? I am new to Yearn, sorry if the questions are silly :p

hehe no worries, I am also trying to figure out how things work
so by the SDK I mean the yearn-sdk called from the VaultService instance
and by the helper contract I mean the strategiesHelper instance, which is a smart contract

Yao · Answer 5 · Wed Mar 23 2022 08:07:19 GMT+0800 (China Standard Time)

what is the data mismatch that you have found? e.g. for solidexJoint, what are the expected results from the sdk and helper contract, and what are the actual output?

borrito · Answer 6 · Wed Mar 23 2022 19:20:33 GMT+0800 (China Standard Time)

what is the data mismatch that you have found? e.g. for solidexJoint, what are the expected results from the sdk and helper contract, and what are the actual output?

tbh I am also new to the codebase, not sure what exactly the expected results should be 🤔
What I have noticed is just that there are more strategies registered in the SDK compared to the helper contract atm (in Fantom)
If you are interested you could call the ABI from the code yourself which is pretty cool hehe

storm0x · Answer 7 · Thu Mar 24 2022 03:59:03 GMT+0800 (China Standard Time)

https://github.com/yearn/yearn-watch/pull/246/files

we need to debug why the entry in fantom is not being picked up.

Strategy_ProviderOfUSDCToNoHedgeSolidexJoint string should match for search string solidexjoint, solidex is a strategy that only exists on fantom

My guess is that having an ethereum group with the fantom and same name gives a problem on matching, can we debug by removing the ethereum group to confirm this is the bug?