Implement Share Management Functions

Question

Implement Share Management Functions

jmonteer opened this issue 2 years ago · comments

Implement Share Management Functions

Description:
Implement deposit
Implement withdraw
Implement share value functions
Implement ERC20 functions

Dependencies:
NA
Acceptance criteria:
Required functions are implemented
Payment Trigger:
PR is merged
Category:
DEV
Level:
1

panda · Answer 1 · Wed Jun 15 2022 23:43:15 GMT+0800 (China Standard Time)

Have we decided on 4626?

anticlimactic · Answer 2 · Thu Jun 16 2022 14:09:00 GMT+0800 (China Standard Time)

I believe @jmonteer wants 4626 to be implemented as a wrapper. This will provide flexibility in allowing integrators to either integrate directly with the vault to deposit / withdraw (relevant for withdrawal, since you can select which strategies you wish to withdraw from) or being lazy and integrating through the wrapper.

jmonteer · Answer 3 · Thu Jun 16 2022 15:45:13 GMT+0800 (China Standard Time)

Yes!

@pandadefi and I discussed this privately but the idea is to leave core code non-compliant and then build a yRouter or yShareToken that is compliant with erc4626