yearn / yearn-vaults-descriptions

Home Page:https://vaults.yearn.finance

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

FRP: Only show strategy desc debt ratio > 0

DarkGhost7 opened this issue Β· comments

What is your proposal πŸš€

Update the site to only pull in current strategies and not all strategies that are active. Generally the best way to do this is by checking if a strategy has a debt ratio > 0. This can be viewed here https://staging.yearn.vision/d/4YCbcel7k/vault-overview?orgId=1&var-networks=FTM&var-exp=false&var-vaults=yvUSDC%200.4.3 Ideally you would use the new api in #56 since with it you can sort strategies this way easily without relying on the subgraph.

What does this solve ? πŸ› 

This makes it so we dont see old outdated strategies on the vault description list.

More πŸ”Ž

N/A

https://ydaemon.yearn.finance/1/vaults/all?strategiesCondition=absolute the strategiesCondition absolute is what we should use here

I can look into this @DarkGhost7, please assign it to me

Done

Done

Thanks! I've created the PR #81 but don't have permissions in this repo to request reviewers or assign the PR to myself. If you'd like feel free to give me those permissions :) otherwise, PR ready for review πŸ™‡ cc @Majorfi @DarkGhost7