Bug: Tokens with additional override paramaters showing up
DarkGhost7 opened this issue · comments
What happened 🆘
https://github.com/yearn/yearn-meta/blob/master/data/tokens/1/0xC4C319E2D4d66CcA4464C0c2B32c9Bd23ebe784e.json#L6
This token is showing up as a token that isn't in the repo when I can see it is in fact already added to the repo. Maybe this is either a cache issue or its due to the override parameters on this specific token.
To Reproduce 🔂
More 🔎
- Browser : Vivaldi
This is the case for all three shown here
This token is showing up as a token that isn't in the repo when I can see it is in fact already added to the repo.
Maybe the wording below is better? It took me a while to figure out what you meant 😄 .
"This token shows up as a missing token on the yearn Vaults site, but I can see it is in fact already added to the repo."
The token addresses are added to the yearn-meta repo, but the vault addresses aren't.
e.g. the vault address for Curve MIM-UST is 0xd8C620991b8E626C099eAaB29B1E3eEa279763bb, but the vault metada file yearn-meta/data/vaults/0xd8C620991b8E626C099eAaB29B1E3eEa279763bb.json is not found in the yearn-meta repo
Happy to raise the PR in the yearn-meta repo if you agree adding vault metadata files fixes the issue.
This token is showing up as a token that isn't in the repo when I can see it is in fact already added to the repo.
Maybe the wording below is better? It took me a while to figure out what you meant 😄 .
"This token shows up as a missing token on the yearn Vaults site, but I can see it is in fact already added to the repo."
Sorry yes that is correct my fault
The token addresses are added to the
yearn-metarepo, but the vault addresses aren't.e.g. the vault address for Curve MIM-UST is
0xd8C620991b8E626C099eAaB29B1E3eEa279763bb, but the vault metada fileyearn-meta/data/vaults/0xd8C620991b8E626C099eAaB29B1E3eEa279763bb.jsonis not found in theyearn-metarepo
Ah I see sorry