Giters

yearn / ape-tax

Home Page:https://ape.tax

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

WFTM / ICE Joint Plugin

poolpitako opened this issue · comments

commented

Description:

This strategy links https://ape.tax/fantombaby with https://ape.tax/fantomsfury
A ProviderStrategy in each vault will provided a usd fixed amount (5k usd) to a Joint contract which will provide liquidity to ICE/WFTM and farm ICE tokens. Once enough profit is made, the strategy will be liquidated and funds return.

Commit (hash): poolpitako/joint-strategy@7834b51

Tag:

Repo: https://github.com/poolpitako/joint-strategy

Scope: (List link to files)

  • Joint.sol
  • ProviderStrategy.sol

Additional References or Repo (Link to underlying protocols or relevant documents):

Deployed Contract (etherscan link):

Review Ongoing By:

Review Completed By:

commented

Reviewed and lgtm.Cleanup and fixes were already done in repo earlier.

commented

Update: Added poolpitako/joint-strategy#5 with the following changes:

  • Renamed gov to governance
  • Renamed pendingGov to pendingGovernance
  • Now Joint's harvest check for reward balance to avoid dumping tokenB balance from provider if reward == tokenB.
  • Added a loss test