<filesystem>: compatibility with Termux on Android
xloem opened this issue · comments
Hi,
The terminal Termux app on Android unfortunately doesn't have the <filesystem> symbols exported: termux/termux-packages#6275 (comment)
Given <filesystem> is such a small part of this project, I was wondering if porting off of <filesystem> would be reasonable, to support users on Termux.
We have a legacy-c++11 branch that uses Boost.Filesystem instead.
If you can figure out how to use <filesystem> with termux, as well as how to detect termux from cmake, we can make it work..
So this was my first search result for filesystem shim libraries: https://github.com/gulrak/filesystem [edit: but I realise now you mean, find where on android these symbols are. it doesn't look like they're present to me, although c++17 works fine otherwise.]
Apparently CMAKE_SYSTEM_NAME is supposed to be set to Android on Termux now, but it is considered better to check for individual features with something like CHECK_LIBRARY_EXISTS: termux/termux-packages#151
That branch sounds like a quick and easy solution :-)
Yeah sorry you’ll have to stick with a legacy version until your OS supports our target requirements.
I'm not seeing a legacy-c++11 branch in your project ...?
Given what you guys have said, I would propose checking for filesystem support in cmake, and also for something like ghc::filesystem at https://github.com/gulrak/filesystem, and recommending installation of ghc, and falling back to it, if filesystem support is not found.
Huh... I could have sworn we tagged the last C++11 commit. Anyway, see ycm-core/YouCompleteMe#3805 (comment)
Thanks. Looks like the branch might have gotten deleted: ycm-core/YouCompleteMe#3805 (comment)
Note: the comment you linked appears to have a typo, linking to ycmd/master rather than an old commit. But I can also git blame the files.
Looks like the branch might have gotten deleted
I think I'm going to blame @puremourning , so I wouldn't have to blame myself. We should tag that thing again.
the comment you linked appears to have a typo, linking to ycmd/master
It links to ycmd commits, because I was lazy and the change was, then, recent.
The horror!
For 4 days, I was sure you had said "honor".
Anyway, I re-pushed legacy-c++11 branch.
Thank you :-)
For 4 days, I was sure you had said "honor".
*honour